Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Azure Linux Image Family Support #72

Merged
merged 27 commits into from
Jan 12, 2024
Merged

feat: Azure Linux Image Family Support #72

merged 27 commits into from
Jan 12, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

Description
This pr adds azure linux support for gen2, gen1 and arm64 images, as well as adds the functionality for GPU support.

How was this change tested?
Added e2e scenarios for

  • arm64 bootstrapping
  • Utilization
  • GPU support for AzureLinux

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

adds azure linux bootstrapping support for gen2, gen1 and arm64 images, as well as adds the functionality for GPU support

Bryce-Soghigian
Bryce-Soghigian commented Dec 18, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Bryce-Soghigian
Bryce-Soghigian commented Dec 18, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Bryce-Soghigian
Bryce-Soghigian commented Dec 18, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Bryce-Soghigian
Bryce-Soghigian commented Dec 18, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian
Copy link
Collaborator Author

Ran 2 of 2 Specs in 322.709 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestArm (322.71s)
PASS
ok github.com/Azure/karpenter/test/suites/arm 323.062s

Both arm suites pass locally

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review December 19, 2023 19:05
@Bryce-Soghigian
Copy link
Collaborator Author

Note Failing GPU Suite is due to a larger issue for Ubuntu GPU Bootstrapping see: #76

This was referenced Dec 21, 2023
Open
Closed
Bryce-Soghigian
Bryce-Soghigian commented Dec 21, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

tallaxes
tallaxes requested changes Jan 4, 2024
View reviewed changes
Bryce-Soghigian
Bryce-Soghigian commented Jan 6, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

rakechill
rakechill reviewed Jan 10, 2024
View reviewed changes
Bryce-Soghigian
Bryce-Soghigian commented Jan 10, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Bryce-Soghigian
Bryce-Soghigian commented Jan 10, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Bryce-Soghigian
Bryce-Soghigian commented Jan 11, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@tallaxes tallaxes added area/gpu Issues or PRs related to GPUs area/bootstrap Issues or PRs related to bootstrap area/vm-images Issues or PRs related to VM images or image galleries kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/instance-types Issues or PRs related to instance types area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework kind/feature Categorizes issue or PR as related to a new feature. labels Jan 11, 2024
Bryce-Soghigian
Bryce-Soghigian commented Jan 11, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

tallaxes
tallaxes approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to passing E2E tests)

@Bryce-Soghigian
Copy link
Collaborator Author

E2E Passed: https://github.com/Azure/karpenter/actions/runs/7493539454

@Bryce-Soghigian Bryce-Soghigian merged commit 06eebbd into main Jan 12, 2024
6 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/azlinux branch January 12, 2024 00:42
@Bryce-Soghigian Bryce-Soghigian mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakechill rakechill rakechill left review comments

@tallaxes tallaxes tallaxes approved these changes

Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
area/bootstrap Issues or PRs related to bootstrap area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework area/gpu Issues or PRs related to GPUs area/instance-types Issues or PRs related to instance types area/vm-images Issues or PRs related to VM images or image galleries kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bryce-Soghigian @tallaxes @rakechill